Use registry for class setup functions #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As part of this, since we do all of the story-specific setup as part of a transaction together with the class creation (so that a class can't be created which is then in a broken state due to setup issues), I've updated our setup to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #164 works fine, I wasn't a huge fan of having to strongly couple the Hubble-specific pieces with the general class-creation method. This PR provides a solution to this - we create a registry for class setup functions, and the individual story modules can then register their particular setup functionality. We can then call all of the relevant class-specific functions from the top-level class-creation method in a generic way.